feat!: Add warm_up method to SnowflakeTableRetriever to delegate auth and database connection testing
#2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrl
requested review from
anakin87 and
medsriha
and removed request for
a team
github-actions
bot
added
integration:snowflake
type:documentation
|
@medsriha would it be possible for you to live test this component against a live Snowflake db? I noticed that we don't have any integration tests for this core integration so it would be good to confirm that it does work as expected. |
medsriha
approved these changes
Oct 21, 2025
anakin87
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
I am OK with this change, also given the low usage of this integration.
Let's remember to:
- check if the example needs an update
- release a new major version
- update docs and integration page
...flake/src/haystack_integrations/components/retrievers/snowflake/snowflake_table_retriever.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
SnowflakeTableRetrieverProposed Changes:
authenticatorwhich matches the previous default behavior. We also set defaults for all Secrets instead of setting them to None by default.warm_upmethod ofSnowflakeTableRetriever. This allows for the component to be initialized without needing all secrets present. This is useful if you want to perform Pipeline validation without needing all secrets present.warm_upon the component before it can be used. This is only relevant if you are using this component in isolation. If being used in a Pipeline then the Pipeline will automatically call warm_up on it so usage of this component does not change.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.