Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update license-header.txt with breaking changes from hawkeye #8778

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 28, 2025

Related Issues

Proposed Changes:

Newest version of hawkeye was released earlier today. it contains breaking changes for how templates work. Check out release notes here.

How did you test it?

Trying to test in the PR #8775 since it will trigger the license header check. The changes in this PR don't seem to trigger it.

Update: The change does fix the failing Tests / format in the PR #8775

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner January 28, 2025 07:52
@sjrl sjrl requested review from anakin87 and removed request for a team January 28, 2025 07:52
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Replacing ${property} with {{ props["property"] }} as described in the hawkeye release notes.

@julian-risch julian-risch removed the request for review from anakin87 January 28, 2025 08:48
@sjrl sjrl merged commit e3dc164 into main Jan 28, 2025
5 checks passed
@sjrl sjrl deleted the fix-license-header branch January 28, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants