fix: warehouse graceful termination and avoid marshalling proc error job payloads#2
Closed
deepshekhardas wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing this combined PR. Will create separate PRs for rudderlabs#6767 and rudderlabs#6872 for easier review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines fixes from two key PRs:
PR rudderlabs#6767 - Warehouse Graceful Termination:
PR rudderlabs#6872 - Avoid Marshalling Proc Error Job Payloads:
Changes:
Summary by cubic
Gracefully handles warehouse router termination by replacing panics with proper errors, and reduces processor overhead by avoiding marshal/unmarshal for error jobs. Prevents crashes and cuts CPU/GC in error paths.
Bug Fixes
warehouse/router(manager init, schema marshal, upload ID scan);state.gonow returns an empty state on invalid input instead of panicking.Performance
procErrorJobwrapping*jobsdb.JobTwith parsed events to avoid marshal/unmarshal; updated maps tomap[string][]procErrorJobinprocessorandpipeline_worker. Removed an unusedjobsdbimport.Written for commit 0d05b4e. Summary will update on new commits.