feat: leak escrow keys

[xorsal]

I'm re-enabling the call to Escrow::leak_keys and have modified the E2E tests so that Bob can claim the escrow's tokens without cheating (i.e., without manually passing it), but instead by retrieving the secret from the private log emitted by the contract.

The nullification_secret in the EscrowKeys event is not currently used, but I'm keeping it for now to explore potential future use cases

[ilpepepig]

This is redundant with get_notes() which seems to constrain the notes according to the options provided.

aztec-standards/src/clawback_escrow/src/main.nr

Line 94 in 8784aa8

assert(unwrapped_note.escrow == escrow, "Invalid escrow address");

Same with these assertions

aztec-standards/src/clawback_escrow/src/main.nr

Line 70 in 8784aa8

assert(note.escrow == escrow, "Invalid escrow address");

aztec-standards/src/clawback_escrow/src/main.nr

Line 57 in 8784aa8

assert(note.escrow == escrow, "Invalid escrow address");

[ilpepepig]

For consistency with claim() let's use note.sender instead of caller?

aztec-standards/src/clawback_escrow/src/main.nr

Line 74 in 8784aa8

Escrow::at(escrow).withdraw(token, amount, caller).call(&mut context);

[ilpepepig]

self.escrow.to_field() can be removed as it is redundant with the content of the note

aztec-standards/src/clawback_escrow/src/types/clawback_escrow_note.nr

Line 29 in 8784aa8

[note_hash_for_nullify, self.escrow.to_field()],

Also, some dependencies imported into the escrow and clawback escrow contracts, and tests are not used.

The nullification_secret in the EscrowKeys event is not currently used, but I'm keeping it for now to explore potential future use cases

Regarding this, if nullification_secret can be derived from the escrow secret, then it is redundant to emit it.

[ilpepepig]

In the escrow and clawback escrow e2e tests, beforeAll() is implemented slightly different. It would be nice to make them consistent.

Also, is this still an issue?

aztec-standards/src/ts/test/clawback.test.ts

Line 44 in 8784aa8

// TODO: why do I need to register Alice's account?

[xorsal]

Closing this, migrated to defi-wonderland/aztec-extensions