Refactoring attempts by Tom den Braber & Michel Kraaijeveld #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tests for UVCoordinatesGenerator now with the actual test file moved math utility functions to proper classes, added tests for the functions that were moved added tests for functions that were moved fixed indentation, added comments added tests to gradle for plugins wrote tests for retrieving subclassname, moved code to proper place created configuration file, refactored and wrote tests for dispatching FbxElements to FbxObjects removed outcommented code removed repositories that are not used anymore fixed wrongly initialized loggers added method comments fixed wrong description Added more UVCoordinatesGenerator tests reverted back to v2.0-beta of mockito removed unused import and restructured import list removed redundant variable took out material loading from sceneloader, added tests for material to object linking more tests for SceneLoader concerning textures extracted FbxTextureLoader, added tests for image/texture link removed incorrect gradle file deduced interface for two loader classes cleaned up gradle file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hereby our squashed commit with our refactoring attempts. For full history you can check out this branch