Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ class DeltaSharingRestClient(
|| customeHeaders.contains(HttpHeaders.USER_AGENT)) {
throw new IllegalArgumentException(
s"HTTP header ${HttpHeaders.AUTHORIZATION} and ${HttpHeaders.USER_AGENT} cannot be"
+ "overriden."
+ "overridden."
)
}
val headers = Map(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ object OpConverter {
*
* @param sqlTypeOpt if specified overrides the dataType specified in
* the SQL expression. It is used to support "cast" method, which
// forces data type convertion during evaluation.
// forces data type conversion during evaluation.
*/
private def maybeConvertAsLeaf(
expr: SqlExpression,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class DeltaSharingServiceExceptionHandler extends ExceptionHandlerFunction {
// requests so these exceptions should never contain sensitive information
// and should be okay to return their messages to the user.
//
// valid json but may not be incorect field type
// valid json but may not be incorrect field type
case (_: scalapb.json4s.JsonFormatException |
// invalid json
_: com.fasterxml.jackson.databind.JsonMappingException) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class JsonPredicateEvaluatorV2(root: BaseOp, reportError: Option[(String) => Uni
// Evaluates an AndOp with the following strategy:
// - If any of its children returns EvalResultFalse, return EvalResultFalse.
// It is safe to discard unknown results from other descendents in this case
// as the overall result is guranteed to be false.
// as the overall result is guaranteed to be false.
// - If none of the children returns EvalResultFalse:
// - If any of them returns EvalResultUnknown, return EvalResultUnknown
// This allows higher layers to perform conservating processing as needed.
Expand Down