[nbhatt] Fix JSON parsing to handle multi-line AddFile objects in delta-sharing response #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found when one of our customers couldn't do a simple
The delta-sharing library is encountering JSONDecodeError exceptions when attempting to parse JSON data from a server response. The issue arises because the client code assumes that each line in the response corresponds to a complete JSON object. However, the JSON data contains embedded newline characters within string values, causing JSON objects to be split across multiple lines. As a result, parsing each line individually fails, leading to JSONDecodeError exceptions.
I wasn't able to figure out how to run Integration Tests locally but if someone could point me in the right direction here so I can write tests for this - please let me know :)