Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sameerawi/rest client delta table version upgrade #629

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Sameerawi/rest client delta table version upgrade #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d91a7d4
Update Python connector version to 30
Dec 27, 2024
f8b65bd
DeltaSharingProfile and Protocol version upgraded
Dec 27, 2024
bf2ff95
reverted the version back to 1.1.0
Dec 30, 2024
9e9798f
Update Python connector version to 32
Dec 30, 2024
be5f0a7
Update Python connector version to 33
Dec 30, 2024
7a39d2e
Update Python connector version to 34
Dec 30, 2024
e50579c
Update Python connector version to 35
Dec 30, 2024
5f45a22
Update Python connector version to 36
Dec 30, 2024
66d9a6e
Update Python connector version to 37
Dec 30, 2024
f82dbab
Included a condition to check if deltaMetadata and deltaProtocol wrap…
Dec 30, 2024
fa51c0a
Reverted the version
Dec 30, 2024
61619d1
fixed the long line issue
Dec 30, 2024
2914a22
fixed the long line issue
Dec 30, 2024
d40a44d
Update Python connector version to 38
Dec 30, 2024
3153f9a
Update Python connector version to 40
Dec 30, 2024
a007ac1
pycodestyle indent issue fixed
Dec 30, 2024
359b2dc
client version reverted
Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/delta_sharing/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

@dataclass(frozen=True)
class DeltaSharingProfile:
CURRENT: ClassVar[int] = 2
CURRENT: ClassVar[int] = 3

share_credentials_version: int
endpoint: str
Expand Down Expand Up @@ -159,7 +159,7 @@ def from_json(json) -> "Table":

@dataclass(frozen=True)
class Protocol:
CURRENT: ClassVar[int] = 1
CURRENT: ClassVar[int] = 3

min_reader_version: int

Expand Down
17 changes: 15 additions & 2 deletions python/delta_sharing/rest_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,24 @@ def query_table_metadata(self, table: Table) -> QueryTableMetadataResponse:
lines = values[1]
protocol_json = json.loads(next(lines))
metadata_json = json.loads(next(lines))

if "deltaProtocol" in protocol_json["protocol"]:
protocol = Protocol.from_json(
json.dumps(protocol_json["protocol"]["deltaProtocol"]))
else:
protocol = Protocol.from_json(json.dumps(protocol_json["protocol"]))

if "deltaMetadata" in metadata_json["metaData"]:
metadata = Metadata.from_json(
json.dumps(metadata_json["metaData"]["deltaMetadata"]))
else:
metadata = Metadata.from_json(json.dumps(metadata_json["metaData"]))

return QueryTableMetadataResponse(
delta_table_version=int(headers.get(
DataSharingRestClient.DELTA_TABLE_VERSION_HEADER)),
protocol=Protocol.from_json(protocol_json["protocol"]),
metadata=Metadata.from_json(metadata_json["metaData"]),
protocol=protocol,
metadata=metadata
)

@retry_with_exponential_backoff
Expand Down
Loading