Include source in maturin build of delta-kernel-rust-sharing-wrapper #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJin-db
force-pushed
the
rust-wrapper-sdist
branch
3 times, most recently
from
f8f0627 to
f9abb6a
Compare
PatrickJin-db
force-pushed
the
rust-wrapper-sdist
branch
from
f9abb6a to
ae7ec18
Compare
linzhou-db
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
maturin build --sdistcreates a source tarball. Uploading the source tarball to PyPI would allow for delta-kernel-rust-sharing-wrapper to be installed from pip even on platforms that do not explicitly have a wheel built for them. This PR updates the README accordingly.