Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed reference of TableClient instance from LogReplay #2646

Closed
wants to merge 6 commits into from

Conversation

rachana-uniyal
Copy link

@rachana-uniyal rachana-uniyal commented Feb 16, 2024

Removed reference of TableClient instance from LogReplay and updated the methods using tableClient to have it as an argument issue #2641

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

How was this patch tested?

Does this PR introduce any user-facing changes?

… the methods using tableClient to have it as an argument
@rachana-uniyal rachana-uniyal changed the title removed reference of TableClient instance from LogReplay #2641 removed reference of TableClient instance from LogReplay Feb 16, 2024
Copy link
Collaborator

@vkorukanti vkorukanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Needs updating the places that call these methods.

LogSegment logSegment,
TableClient tableClient,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the TableClient as the first argument here and all below functions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, Thanks for the Info.

@vkorukanti
Copy link
Collaborator

Fixed as part of #3165

@vkorukanti vkorukanti closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants