Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Honor codegen configs in DataSkippingStatsTracker #4120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −8
Open

[Spark] Honor codegen configs in DataSkippingStatsTracker #4120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9c9add
makes DataSkippingStatsTracker aware of codegen configs
LukasRupprecht Jan 31, 2025
0b93912
addresses comment
LukasRupprecht Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions spark/src/main/scala/org/apache/spark/sql/delta/stats/DataSkippingStatsTracker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,11 @@ class DeltaTaskStatisticsTracker(

// This projection combines the intermediate results stored by aggBuffer with the values of the
// currently processed row and updates aggBuffer in place.
private val updateStats: MutableProjection = GenerateMutableProjection.generate(
expressions = JoinedProjection.bind(
aggBufferAttrs,
dataCols,
aggregates.flatMap(_.updateExpressions)),
inputSchema = Nil,
useSubexprElimination = true
)
private val updateStats: MutableProjection = {
val aggs = aggregates.flatMap(_.updateExpressions)
val expressions = JoinedProjection.bind(aggBufferAttrs, dataCols, aggs)
MutableProjection.create(expressions, Nil)
}

// This executes the whole statsColExpr in order to compute the final stats value for the file.
// In order to evaluate it, we have to replace its aggregate functions with the corresponding
Expand Down
Loading