You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cargo clippy errors are worth addressing, there are some around futures not being resolved which is definitely a bad runtime behavior. Running the build and tests locally is looking generally good. @mightyshazam do you mind if I pull this into a topic branch on this repository, and then we can collaborate on cleaning it up for merge and release?
The cargo clippy errors are worth addressing, there are some around futures not being resolved which is definitely a bad runtime behavior. Running the build and tests locally is looking generally good. @mightyshazam do you mind if I pull this into a topic branch on this repository, and then we can collaborate on cleaning it up for merge and release?
@mightyshazam I have pushed the azure-writes branch and sent you an invite to act as a collaborator on this repo for that branch. I will close this pull request in favor of the draft: #136
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an extension of #114 by @thovoll . It fixes the broken tests, adds support for ARM and adds a test for Azure Blob Storage using Azurite.