-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve styles in shortcut hint #4588
base: main
Are you sure you want to change the base?
Conversation
- add alternative shortcut to open shortcut hints
Of course the dialog now needs much more space, what can be considered worse... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better on the screenshot, but on not-super-tall screens it's really weird.
2025-01-31-3hUo8q06sz.mp4
I don't think it should be horizontally scrollable.
Well otherwise you have a narrow window but have to scroll a lot. Not what I would expect if I have a wide enough screen. |
Looks weird. So you have a screen with less than 760px height, on the other hand no scrollbar? |
No no, there is a scrollbar. I scrolled it to bottom, it's fine in this regard. |
So I reduced the paddings and margins so that scrolling with 2 columns is less often used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding-left: 10px; | ||
padding-bottom: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
.keyboard-hint-dialog-body { | ||
display: flex; | ||
flex-wrap: wrap; | ||
flex-direction: column; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before:
After:
#skip-changelog