perf: fewer MessageList re-renders
#4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. Apologies for forgetting to mention this. |
Don't re-render it on unread count change. Namely, when scrolling through unread messages.
WofWca
force-pushed
the
wofwca/perf-message-list
branch
from
766baba to
77fe38d
Compare
WofWca
added a commit
that referenced
this pull request
Feb 15, 2025
Reproduction steps: 1. Open a chat. 2. Scroll it up. 3. Receive a message or a few in this chat. 4. Scroll down to read all the new messages. The counter will be updating as you read the messages, as expected. 5. Scroll up a bit. The "jump down" button will appear again, but with an incorrect count. The bug was introduced in 1a752fa (#4594). This commit somewhat reverts it, i.e. ensures that `useUnreadCount` does not lose its state when we start / stop displaying the "jump down" button.
WofWca
added a commit
that referenced
this pull request
Feb 17, 2025
Reproduction steps: 1. Open a chat. 2. Scroll it up. 3. Receive a message or a few in this chat. 4. Scroll down to read all the new messages. The counter will be updating as you read the messages, as expected. 5. Scroll up a bit. The "jump down" button will appear again, but with an incorrect count. The bug was introduced in 1a752fa (#4594). This commit somewhat reverts it, i.e. ensures that `useUnreadCount` does not lose its state when we start / stop displaying the "jump down" button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.