2 - document that rebasing token share quantities must be equivalent to their wrapped quantities #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heir wrapped quantities
MrToph
reviewed
Dec 21, 2024
|
|
||
| | :exclamation: IMPORTANT | | ||
| | :------------------------------------------------------------------------------------------------------------- | | ||
| | Only rebasing tokens whos "share" token quantities equal the wrapped token quantities can be used (EX: StETH). | |
MrToph
reviewed
Dec 21, 2024
Comment on lines
+125
to
+126
| If deposits/redemptions to the strategy are not permissioned, this should be set | ||
| to at least the yield accrual interval of hyperdrive (typically 1 day). |
There was a problem hiding this comment.
I thought in practice you'll always use a vault? Because, otherwise your assumptions that the strategy's idle is close to 0 does not hold, for example.
jalextowle
approved these changes
Jan 7, 2025
Contributor
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
Approved when cmichel's comments are addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The everlong strategy requires that to use a wrapped token, the rebasing share quantities must be equivalent to the wrapped token quantities.
This PR adds documentation around this requirement.
issue