5 - closePositions respects minimumTransactionAmount (depends on 4) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperdrive returns the minimum transaction amount in base and rounds up when handling conversions. Previously, it was not being converted in some places and values were rounded down. This pr unifies the minimum transaction amount calculation and adds a buffer to overestimate it.
mcclurejt
changed the title
MrToph
reviewed
Jan 1, 2025
MrToph
reviewed
Jan 1, 2025
Remove additional conversion for wrapped tokens since the wrapped token denominations are the same as hyperdrive's vault shares token.
Currently, `closePositions(..)` does not check whether a partial closure will result in a position value less than the minimum transaction amount. This PR adds the necessary logic for this check as well as a test to ensure it is behaving as expected. [issue](https://cantina.xyz/code/4f25dfd5-d3e6-4e7a-9481-d7306b795f2b/findings/5)
mcclurejt
force-pushed
the
mcclurejt/fix/close-positions-respect-min-tx-amount
branch
from
e6060fd to
8464f8c
Compare
No conversions are needed for min tx amount when closing longs since it's denominated in bonds not execution tokens
jalextowle
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
closePositions(..)does not check whether a partial closure will result in a position value less than the minimum transaction amount.This PR adds the necessary logic for this check as well as a test to ensure it is behaving as expected.
issue
depends on changes from the fix for 4