Adding wmql^T (roi_querier script) - No functionallity yet#48
Open
gagdiez wants to merge 1 commit intodemianw:masterfrom
Open
Adding wmql^T (roi_querier script) - No functionallity yet#48gagdiez wants to merge 1 commit intodemianw:masterfrom
gagdiez wants to merge 1 commit intodemianw:masterfrom
Conversation
This commit prepares the repository to welcome the new script "roi_querier". Some small errors were also fixed. The main changes are: 1. The code that parses/transforms a query into a tree has been removed from scripts/tract_querier and made into a function: search_file_and_create_query_body. It is located in the file tract_querier/__init__.py. This allows us to share the query-parsing in both "roi_querier" and "tract_querier". 2. The function to parse the queries now returns a "file not found" error when the file.qry does not exists. This is much more informative than the current "error in query file" 3. The test were givin some encoding-related errors with the files freesurfer_queries_bsf2016*. This have been fixed.
gagdiez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prepares the repository to welcome the new script "roi_querier". Some small errors were also fixed. The main changes are:
The code that parses/transforms a query into a tree has been removed from scripts/tract_querier and made into a function:
search_file_and_create_query_body. It is located in the file tract_querier/init.py. This allows us to share the query-parsing
in both "roi_querier" and "tract_querier".
The function to parse the queries now returns a "file not found" error when the file.qry does not exists. This is much more
informative than the current "error in query file"
The test were giving some encoding-related errors with the files freesurfer_queries_bsf2016*. This have been fixed.