Skip to content

Comments

Changed test_query_eval to use pytest fixtures#74

Open
demianw wants to merge 1 commit intomasterfrom
fix_test_query_eval
Open

Changed test_query_eval to use pytest fixtures#74
demianw wants to merge 1 commit intomasterfrom
fix_test_query_eval

Conversation

@demianw
Copy link
Owner

@demianw demianw commented Dec 11, 2024

addressing issue #69

@demianw
Copy link
Owner Author

demianw commented Dec 11, 2024

@jhlegarreta do you want to check this PR fixing the test issue #69 ?

@jhlegarreta
Copy link
Contributor

@demianw I have checkout the branch and ran ppytest on the file 100 times 4 times using the pytest-repeat package; first time all passed, next three times, it failed:

Passed:

Failed:

Failed:

So the change does not fix the issue. Feel free to merge it if you believe it constitutes an improvement anyways or if you think it will allow debugging this better.

@demianw
Copy link
Owner Author

demianw commented Dec 11, 2024

Thanks for the insight. I will test with pytest-repeat as you recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants