Conversation
Prefer absoulute import statements: Python PEP 8 recomends using absolute imports: https://peps.python.org/pep-0008/#imports "Absolute imports are recommended, as they are usually more readable and tend to be better behaved (or at least give better error messages) (...)."
|
Keeping this as a draft until a tag/release is made. xref: #67 (comment) |
|
I disagree with this one. Most packages, for instance scikit learn or nilearn, for instance use relative imports. |
Please don't keep them as drafts if you want me to review them, just keep them as draft if they are work in progress. Even if you think we should make a tag/release |
|
I still believe absolute imports are helpful, but do not have other arguments at present. |
Was keeping them as drafts to avoid accidentally merging them before tagging. I know tagging can be done from any given commit, but thought it was cleaner this way. |
|
Let's keep this one for further discussion and continue moving forward with other PRs. Thanks for such a granular work ! If you look at sklearn's code, all imports are relative e. g. : https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/linear_model/__init__.py |
Prefer absoulute import statements: Python PEP 8 recomends using absolute imports:
https://peps.python.org/pep-0008/#imports
"Absolute imports are recommended, as they are usually more readable and tend to be better behaved (or at least give better error messages) (...)."