fix: persist add-reminder date (send under reminder, not reminder_date) - #58
Open
nico-fioretti wants to merge 1 commit into
Open
Conversation
An absolute reminder must be sent under the reminder key. The TaskReminder type calls it reminder_date, but the server expects reminder and otherwise stores a zero (0001-01-01) reminder that never fires. Reads/writes the reminder field and preserves existing reminders.
netadvanced
referenced
this pull request
in netadvanced/vikunja-mcp-ng
Jul 17, 2026
fix: persist add-reminder under the reminder API field (re-implements upstream #58 by @nico-fioretti)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
add-reminderreports success but the reminder is stored with a zero date (0001-01-01T00:00:00Z), so it never fires.The Vikunja task model exposes an absolute reminder under the
reminderkey, butTaskReminderand the reminder write path usereminder_date. The server ignores the unknownreminder_datefield and leavesreminderat its zero value.Verified against Vikunja v2.3.0:
add-reminderwith a valid date producedreminders: [{ "reminder": "0001-01-01T00:00:00Z" }]on a subsequentget.Fix
addRemindernow reads and writes thereminderfield (preserving any existing reminders, including relative ones) and casts the body forupdateTask, which forwards it verbatim. After the change the same call persists the real date (e.g.reminder: "2028-02-28T09:00:00+01:00").Tests
Adds
tests/reminder-persistence.test.ts: asserts the update body sendsreminderand neverreminder_date, and that existing reminders are preserved.Note
There is a sibling bug in the assignee path (the bulk-assign endpoint responds 2xx but does not persist on current servers; assigning via the single-assignee endpoint works). That is the same area #34/#43 touch from the detection angle, so it is intentionally left out of this PR to keep the reminder fix self-contained.