Implement CLASS attribute of ics files #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keinstein, you may want the patch indicated by pull request #162. It looks like the addition of the calss attribute triggered a latent bug in the main repo. Pull request #162 contains a fix for that. |
|
@niclasborlin Thanks, I checked out your master branch with the additonal patches for personal use and testing. Nevertheless I think #162 is worth to be integrated independently into upstream. |
dakra
added a commit
to dakra/org-caldav
that referenced
this pull request
Jun 27, 2019
Mention that PRs dengste#141, dengste#159, dengste#161, dengste#167, dengste#169, dengste#170, dengste#178, dengste#179 are included plus additional commits.
dakra
added a commit
to dakra/org-caldav
that referenced
this pull request
Jun 27, 2019
Mention that PRs dengste#141, dengste#159, dengste#161, dengste#167, dengste#169, dengste#170, dengste#180, dengste#181 are included plus additional commits.
|
@keinstein You introduce org-caldav-change-class but it is never called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the CLASS attribute for CalDAV servers. It is completely copy&paste&(search&replace) from the LOCATION attribute.
This is the companion patch to patch b32415dede200746f9bc75c247379a389f76db1e from org-mode.
This allows to control the visibilty of calendar entries. This is necessary to properly synchronize semi-public calendars, for example public and private performances of a band in one calendar.
BTW. I didn't know how to introduce this feature to README.md. LOCATION is mentioned there as unhandled, but both ox-icalendar and org-caldav support it.