Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/unstable): add link and linkSync #6369

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

jbronder
Copy link
Contributor

This PR adds the link and linkSync APIs to @std/fs, which are functions intended to mirror Deno.link and Deno.linkSync, respectively.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner January 28, 2025 21:04
@github-actions github-actions bot added the fs label Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (f30741c) to head (b991d31).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_link.ts 51.72% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6369      +/-   ##
==========================================
- Coverage   96.31%   96.28%   -0.04%     
==========================================
  Files         553      554       +1     
  Lines       41973    42002      +29     
  Branches     6360     6363       +3     
==========================================
+ Hits        40426    40441      +15     
- Misses       1507     1521      +14     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit 730fd2e into denoland:main Jan 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants