-
Notifications
You must be signed in to change notification settings - Fork 655
chore: add Darwin and Windows OS's to node test runner #6711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: add Darwin and Windows OS's to node test runner #6711
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6711 +/- ##
==========================================
- Coverage 94.65% 94.62% -0.03%
==========================================
Files 576 576
Lines 47059 47070 +11
Branches 6608 6608
==========================================
- Hits 44543 44542 -1
- Misses 2474 2485 +11
- Partials 42 43 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Some of the |
We generally don't merge PRs to main which makes CI check red. Can you try to address those issues in this PR? |
That makes sense, I'll take a look. |
Quick progress update: I decided to tackle |
Addresses #6636. This PR adds Windows and MacOS the
matrix.os
variable to expand the CI workflow of the Node test runner.