Skip to content

Commit

Permalink
Remove googletest visibility workaround in BUILD.gn
Browse files Browse the repository at this point in the history
  • Loading branch information
littledivy authored and github-actions[bot] committed Feb 4, 2025
1 parent 1d6e939 commit 929ded0
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions third_party/googletest/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("../../gni/v8.gni")

config("gtest_config") {
visibility = [ ":*" ] # gmock also shares this config.

Expand Down Expand Up @@ -91,14 +89,6 @@ source_set("gtest") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]

# V8-only workaround for http://crbug.com/chromium/1191946. Ensures that
# googletest is compiled with the same visibility such as the rest of V8, see
# https://source.chromium.org/chromium/chromium/src/+/master:v8/gni/v8.gni
if ((is_posix || is_fuchsia) && (v8_enable_backtrace || v8_monolithic)) {
configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
configs += [ "//build/config/gcc:symbol_visibility_default" ]
}

deps = []

if (is_fuchsia) {
Expand Down Expand Up @@ -143,14 +133,6 @@ source_set("gmock") {
"src/googlemock/src/gmock.cc",
]

# V8-only workaround for http://crbug.com/chromium/1191946. Ensures that
# googletest is compiled with the same visibility such as the rest of V8, see
# https://source.chromium.org/chromium/chromium/src/+/master:v8/gni/v8.gni
if ((is_posix || is_fuchsia) && (v8_enable_backtrace || v8_monolithic)) {
configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
configs += [ "//build/config/gcc:symbol_visibility_default" ]
}

public_configs = [
":gmock_config",
":gtest_config",
Expand Down

0 comments on commit 929ded0

Please sign in to comment.