Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match filename in xvlog linter and add tip #4764

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gastmaier
Copy link

Match the xvlog stdout for the filename to properly filter out the errors per file.
Suggest using Vivado generated compile.sh file to obtain the xvlog options.

For reference, the sane way of using xvlog is along these lines:

let g:ale_verilog_xvlog_options = '
\ --incr --relax \
\ -L uvm -L axi_vip_v1_1_15 -L smartconnect_v1_0 -L clk_vip_v1_0_3 -L axi4stream_vip_v1_1_15 -L rst_vip_v1_0_5 -L xilinx_vip
\ -prj ./path/to/xsim/system_tb_vlog.prj'

Room for improvement:
The .prj uses relative paths and expects xvlog to be called from its path.
As is, I'm manually "fixing" the relative paths in the .prj to point from the cwd to xsim.
Not sure if it's worth a more elaborated solution (e.g. search for the compile.sh, set cwd to its location, and extract the xvlog options.

Match the xvlog stdout for the filename to properly filter out the
errors per file.
Suggest using Vivado generated compile.sh file to obtain the xvlog
options.
The linter added warnings to the stdout.
Copy link

stale bot commented Feb 1, 2025

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PRs/Issues no longer valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant