Skip to content

fix: store raw response in APIError during JSON parsing #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: store raw response in APIError during JSON parsing #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions response/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,15 @@ func HandleAPIErrorResponse(resp *http.Response, sugar *zap.SugaredLogger) *APIE

// parseJSONResponse attempts to parse the JSON error response and update the APIError structure.
func parseJSONResponse(bodyBytes []byte, apiError *APIError) {
apiError.RawResponse = string(bodyBytes)

if err := json.Unmarshal(bodyBytes, apiError); err != nil {
apiError.RawResponse = string(bodyBytes)
} else {
if apiError.Message == "" {
apiError.Message = "An unknown error occurred"
}

}

}

// parseXMLResponse dynamically parses XML error responses and accumulates potential error messages.
Expand Down