Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 팔로우/언팔로우 시 데이터 실시간 반영 #455

Merged
merged 1 commit into from
Nov 17, 2024
Merged

fix: 팔로우/언팔로우 시 데이터 실시간 반영 #455

merged 1 commit into from
Nov 17, 2024

Conversation

summermong
Copy link
Collaborator

🤔 어떤 문제가 발생했나요?

  • 팔로우/언팔로우 시 프로필의 숫자가 바로 반영되지 않고, 페이지를 이탈해야만 확인할 수 있습니다.
  • fetchProfileData에 staleTime이 infinity로, 캐싱이 되어 있는 게 원인이었습니다.

🎉 어떻게 해결했나요?

  • 바람직하진 않지만 매 요청을 다시 보내도록 staleTime을 삭제했습니다.
  • 해당 부분은 팔로우/언팔로우 시 우선 ui에서 업데이트를 진행하는 낙관적 업데이트로 추후 수정하면 좋을 것 같습니다!

📷 이미지 첨부 (Option)

Uploading 화면 기록 2024-11-12 오후 8.52.21.mov…

⚠️ 유의할 점! (Option)

@summermong summermong added the fix # Fix bug label Nov 12, 2024
@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Nov 12, 2024
wokbjso
wokbjso approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@wokbjso wokbjso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선 이렇게 임시조치 하시죠~~👍

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Nov 15, 2024
@summermong summermong merged commit 00b5069 into main Nov 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wokbjso wokbjso wokbjso approved these changes

@hjy0951 hjy0951 Awaiting requested review from hjy0951 hjy0951 is a code owner

@Jungjjeong Jungjjeong Awaiting requested review from Jungjjeong Jungjjeong is a code owner

Assignees

@summermong summermong

Labels
Approved 🆗 # Review is completed fix # Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@summermong @wokbjso @king2dwellsang