added new ci/cd #77
added new ci/cd #77
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces CI/CD improvements and removes unused "cordshare" functionality from the codebase.
- Adds automated artifact cleanup and prerelease management scripts
- Removes cordshare feature from client settings and agent arguments
- Cleans up debug logging in client commands
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src-tauri/src/core/storage/settings.rs | Commented out cordshare setting definition |
| src-tauri/src/core/clients/internal/agent_overlay.rs | Removed cordshare field from AgentArguments struct and methods |
| src-tauri/src/core/clients/client.rs | Commented out cordshare setting usage in client initialization |
| src-tauri/src/commands/clients.rs | Removed debug log statement from get_app_logs function |
| scripts/remove_releases.py | Added Python script for managing GitHub prerelease cleanup |
| .github/workflows/cleanup-artifacts.yml | Added GitHub workflow for automated artifact cleanup |
Comments suppressed due to low confidence (1)
src-tauri/src/core/clients/internal/agent_overlay.rs:1
- The commented self.cordshare argument should be completely removed from the log_info! macro call rather than commented out.
use crate::core::network::servers::SERVERS;
| token: String, | ||
| client_name: String, | ||
| analytics: bool, | ||
| cordshare: bool, | ||
| // cordshare: bool, | ||
| ircchat: bool, |
There was a problem hiding this comment.
Instead of commenting out the cordshare field, it should be completely removed from the struct definition to avoid dead code. The commented code can cause confusion and should be cleaned up.
| token: String, | ||
| client_name: String, | ||
| analytics: bool, | ||
| cordshare: bool, | ||
| // cordshare: bool, | ||
| ircchat: bool, |
There was a problem hiding this comment.
The commented cordshare parameter should be removed from the constructor function signature rather than commented out to maintain clean code.
| Self { | ||
| token, | ||
| client_name, | ||
| analytics, | ||
| cordshare, | ||
| // cordshare, | ||
| ircchat, | ||
| } |
There was a problem hiding this comment.
Remove the commented cordshare field assignment from the struct initialization to eliminate dead code.
| discord_rpc_enabled: Setting<bool> = (true, true), | ||
| optional_telemetry: Setting<bool> = (true, true), | ||
| cordshare: Setting<bool> = (true, true), | ||
| // cordshare: Setting<bool> = (true, true), |
There was a problem hiding this comment.
Instead of commenting out the cordshare setting, it should be completely removed from the settings definition to avoid confusion and maintain clean code.
| // cordshare: Setting<bool> = (true, true), |
| let app_handle_clone_for_crash_handling = options.app_handle.clone(); | ||
| let optional_analytics = SETTINGS.lock().is_ok_and(|s| s.optional_telemetry.value); | ||
| let cordshare = SETTINGS.lock().is_ok_and(|s| s.cordshare.value); | ||
| // let cordshare = SETTINGS.lock().is_ok_and(|s| s.cordshare.value); |
There was a problem hiding this comment.
Remove the commented cordshare variable declaration entirely rather than leaving it as a comment to maintain clean code.
| // let cordshare = SETTINGS.lock().is_ok_and(|s| s.cordshare.value); |
| optional_analytics | ||
| }, | ||
| cordshare, | ||
| // cordshare, |
There was a problem hiding this comment.
The commented cordshare argument should be completely removed from the AgentArguments::new call rather than commented out.
| // cordshare, |
No description provided.