Skip to content
This repository was archived by the owner on May 25, 2026. It is now read-only.

fix(client): tailor 403 guidance to PAT vs CI job token (DOT-432) - #104

Merged
ichoosetoaccept merged 3 commits into
detailobsessedfrom
ismart/dot-432-improve-403-error-guidance-for-ci_job_token-users
May 15, 2026
Merged

fix(client): tailor 403 guidance to PAT vs CI job token (DOT-432)#104
ichoosetoaccept merged 3 commits into
detailobsessedfrom
ismart/dot-432-improve-403-error-guidance-for-ci_job_token-users

Conversation

@ichoosetoaccept

@ichoosetoaccept ichoosetoaccept commented May 15, 2026

Copy link
Copy Markdown
Member

Tailor 403 error guidance to PAT vs CI job token in GitLabClient

Previously, all 403 errors showed generic PAT scope guidance, which was not actionable for CI job token users. Now, throwIfForbidden in gitlab-client.ts calls a new scopeGuidance(tokenHeader) function that returns token-type-specific messages: PAT users see guidance about Access Token scopes, while CI job token users are directed to their project's CI/CD token access settings.

🖇️ Linked Issues

Resolves DOT-432, which identified that CI job token users received misleading PAT-specific guidance on 403 errors.

Macroscope summarized a6675e7.

Ismar Iljazovic added 3 commits May 15, 2026 12:56
Bundled housekeeping pass:

- Bump all 5 outdated packages to latest (all minor/patch):
  - dotenv 17.4.1 -> 17.4.2
  - zod 4.3.6 -> 4.4.3
  - @biomejs/biome 2.4.10 -> 2.4.15
  - @types/bun 1.3.11 -> 1.3.14
  - @types/node 25.5.2 -> 25.8.0
- Bump biome.json $schema URL to match the new Biome version (was
  pinned to 2.3.10, lagging the actual installed version).
- Ignore .claude/worktrees/ and .serena/ in .gitignore so agent-harness
  state stops leaking into git status — and, more importantly, stops
  breaking 'bun run check' (Biome's config discovery was treating the
  worktree biome.json copies as nested root configurations and bailing).

Verified: bun run check, bun run build, bun test all green (292 pass).
@ichoosetoaccept

Copy link
Copy Markdown
Member Author

@linear-code

linear-code Bot commented May 15, 2026

Copy link
Copy Markdown

DOT-432

@macroscopeapp

macroscopeapp Bot commented May 15, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved

This PR improves 403 error messages by providing guidance tailored to the authentication method (PAT vs CI job token). The change only affects error message text, includes tests, and carries no risk to runtime behavior beyond better diagnostics.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 15, 2026
Base automatically changed from docs/branch-workflow to detailobsessed May 15, 2026 11:41
@macroscopeapp
macroscopeapp Bot dismissed their stale review May 15, 2026 11:41

Dismissing prior approval to re-evaluate a6675e7

@ichoosetoaccept
ichoosetoaccept merged commit 868bab2 into detailobsessed May 15, 2026
3 checks passed
@ichoosetoaccept
ichoosetoaccept deleted the ismart/dot-432-improve-403-error-guidance-for-ci_job_token-users branch May 15, 2026 11:43
github-actions Bot pushed a commit that referenced this pull request May 15, 2026
## [2.28.2](v2.28.1...v2.28.2) (2026-05-15)

### Bug Fixes

* **client:** tailor 403 guidance to PAT vs CI job token (DOT-432) ([#104](#104)) ([868bab2](868bab2))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.28.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant