Feat/193 env config validation#245
Merged
determined-001 merged 3 commits intodetermined-001:mainfrom May 1, 2026
Merged
Conversation
added 2 commits
April 28, 2026 13:30
…stream management
…on, and a webhook registry service
|
Someone is attempting to deploy a commit to the determined's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Chrisbankz0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Removes duplicate inline NETWORK/PORT validation from index.ts and routes all environment access through the typed config module, keeping pino logger and graceful shutdown intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #193
This PR addresses the compounding ad-hoc validation of environment variables by centralizing them into a single typed configuration schema.
Previously, environment variables like
NETWORK,PORT,API_KEY, andWEBHOOK_SECRETwere validated disparately acrossindex.ts,auth.ts, andregistry.ts. This ad-hoc validation approach made it difficult to scale safely and predictably as new variables were planned to be introduced.This PR ensures that all environment variables are parsed, strictly validated, and logged exactly once during server startup.
Changes Made
apps/server/src/config.ts: Created a centralized config module with a handwritten schema that extracts, validates, and exports a fully typedServerConfigobject.API_KEYandWEBHOOK_SECRET) being automatically redacted.process.envchecks fromindex.ts,auth.ts, andregistry.ts, migrating them to securely consume the globally exportedconfigobject.Testing Notes
NETWORKandAPI_KEYnow results in a fatal error logging both missing variables.PORT=abcthrows a validation error for the port.NETWORKandPORTwhile renderingAPI_KEYandWEBHOOK_SECRETas***REDACTED***.#closes