Skip to content

Fix/code highlighting #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix/code highlighting #8

wants to merge 2 commits into from

Conversation

micheleriva
Copy link

@micheleriva micheleriva commented Oct 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (what?)

🔗 Related issue link

Fixes #7

💡 Background and solution

Highlight.js was working only with the onBlur event. Now it works as soon as you type new code.

📝 Changelog

Language Changelog
🇺🇸 English Fixed highlight.js on keyUp event

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo/Example is updated/provided or not needed
  • Changelog is provided or not needed

This fix was possible thanks to this StackOverflow thread, I'll leave here the link for credits: https://stackoverflow.com/a/52347981/6442285

@micheleriva micheleriva marked this pull request as draft October 5, 2020 18:39
@micheleriva
Copy link
Author

Converted the current PR to draft, I want to make some tests before asking for a review

@mqtik
Copy link

mqtik commented Mar 20, 2021

@micheleriva what's the status of this PR?
Would love to try it out

@micheleriva
Copy link
Author

@mqtik I'm not working on that anymore, I had to switch to another plugin. Sorry 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code highlighting
2 participants