Skip to content

Conversation

@dev-madhurendra
Copy link
Owner

@dev-madhurendra dev-madhurendra commented Aug 11, 2025

πŸ“¦ Pull Request

πŸ“Œ Description

Fixes #

🧩 Type of Change

Please delete options that are not relevant.

  • πŸ› Bug fix
  • ✨ New feature
  • ♻️ Code refactor
  • πŸ§ͺ Test addition/changes
  • πŸ“ Documentation update
  • πŸš€ Performance improvement
  • πŸ”§ Build/deployment changes
  • ⚠️ Breaking change

βœ… Checklist

  • I have followed the project's coding standards
  • I have tested the changes locally
  • All dependent packages are updated (if needed)
  • I have added or updated relevant documentation/comments
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed
  • I have linked the related issue (if applicable)

πŸ§ͺ How to Test

  1. Start backend server
  2. Run frontend with npm run dev
  3. Test /api/barber/token endpoint manually or using Postman
  4. [Optional] Check console logs or database

πŸ“Έ Screenshots / Video

πŸ” Review Notes

  • Focus on validation logic in BarberTokenController
  • Ensure role-based access is working correctly

🚨 Breaking Changes?

  • Yes (please describe below)
  • No

If yes, please describe:

πŸ“š Additional Context

@dev-madhurendra dev-madhurendra self-assigned this Aug 11, 2025
@dev-madhurendra dev-madhurendra added the enhancement New feature or request label Aug 11, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.9% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

@dev-madhurendra dev-madhurendra merged commit fc4f800 into main Aug 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants