Skip to content

Conversation

@aritraghorai
Copy link

@aritraghorai aritraghorai commented Aug 15, 2025

📦 Pull Request

📌 Description

Added setup for docker images and added build config as per spring oci docs

https://docs.spring.io/spring-boot/maven-plugin/build-image.html#build-image.customization.tags

Fixes #

🧩 Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Code refactor
  • 🧪 Test addition/changes
  • 📝 Documentation update
  • 🚀 Performance improvement
  • 🔧 Build/deployment changes
  • ⚠️ Breaking change

✅ Checklist

  • I have followed the project's coding standards
  • I have tested the changes locally
  • All dependent packages are updated (if needed)
  • I have added or updated relevant documentation/comments
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed
  • I have linked the related issue (if applicable)

🧪 How to Test

  1. Start backend server
  2. Run frontend with npm run dev
  3. Test /api/barber/token endpoint manually or using Postman
  4. [Optional] Check console logs or database

📸 Screenshots / Video

🔍 Review Notes

  • Focus on validation logic in BarberTokenController
  • Ensure role-based access is working correctly

🚨 Breaking Changes?

  • Yes (please describe below)
  • No

If yes, please describe:

📚 Additional Context

Copy link
Owner

@dev-madhurendra dev-madhurendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file compose.yml to docker-compose.yml

@aritraghorai
Copy link
Author

The Docker documentation recommends using compose.yml as the preferred filename for Docker Compose files. This change was introduced in Docker Compose version 1.28.6 in 2021.

@dev-madhurendra
Copy link
Owner

The Docker documentation recommends using compose.yml as the preferred filename for Docker Compose files. This change was introduced in Docker Compose version 1.28.6 in 2021.

Great, thanks for the info

@dev-madhurendra dev-madhurendra changed the title Feat:Added backend deployment setup 🚀 feat : added backend deployment setup Aug 15, 2025
@dev-madhurendra dev-madhurendra merged commit b8d4db8 into dev-madhurendra:main Aug 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants