Skip to content

Conversation

@aritraghorai
Copy link

πŸ“¦ Pull Request

πŸ“Œ Description

Fixes #

🧩 Type of Change

Please delete options that are not relevant.

  • πŸ› Bug fix
  • ✨ New feature
  • ♻️ Code refactor
  • πŸ§ͺ Test addition/changes
  • πŸ“ Documentation update
  • πŸš€ Performance improvement
  • πŸ”§ Build/deployment changes
  • ⚠️ Breaking change

βœ… Checklist

  • I have followed the project's coding standards
  • I have tested the changes locally
  • All dependent packages are updated (if needed)
  • I have added or updated relevant documentation/comments
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed
  • I have linked the related issue (if applicable)

πŸ§ͺ How to Test

  1. Start backend server
  2. Run frontend with npm run dev
  3. Test /api/barber/token endpoint manually or using Postman
  4. [Optional] Check console logs or database

πŸ“Έ Screenshots / Video

πŸ” Review Notes

  • Focus on validation logic in BarberTokenController
  • Ensure role-based access is working correctly

🚨 Breaking Changes?

  • Yes (please describe below)
  • No

If yes, please describe:

πŸ“š Additional Context

@dev-madhurendra dev-madhurendra changed the title Feat:Added Tanstack router and zustand for state mangement ✨ feat : added Tanstack router and zustand for state mangement Aug 17, 2025
@dev-madhurendra dev-madhurendra added the enhancement New feature or request label Aug 17, 2025
@dev-madhurendra
Copy link
Owner

Hi @aritraghorai
I was reviewing your PR there is one issue although UI is working fine but throwing error

Error: EPERM: operation not permitted, rename '.tanstack\tmp\8afcbc5d-81c03bf0bd9f247d05749ec798ed16cf' ->

Please look into this.

@dev-madhurendra
Copy link
Owner

Hi @aritraghorai I was reviewing your PR there is one issue although UI is working fine but throwing error

Error: EPERM: operation not permitted, rename '.tanstack\tmp\8afcbc5d-81c03bf0bd9f247d05749ec798ed16cf' ->

Please look into this.

Before reviewing code i was reviewing that every functionality is working or not but some are broken pls fix that.

  1. After login getting something went wrong with router
  2. Not found page button is not redirecting to the main page

Pls ensure before raising PR that functionalities are not affected.

Copy link
Owner

@dev-madhurendra dev-madhurendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that functionalities are working as expected.

@aritraghorai
Copy link
Author

Yeh that's common will discuss and fix the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants