[wip] Babel support #39

Andarist · 2018-01-09T20:28:01Z

Just a starter - need to figure out what else needs to be done to support this within your vision's frame 😉 any particular requirements come to your mind?

fixes #25

developit · 2018-01-10T15:08:09Z

Thanks for the awesome start @Andarist! I think the only things on my mind here were to make sure we were on Babel 7 so we get the updated ultra-compact loose mode and support for blacklisting regenerator (so we can still use nodent or fast-async).

developit · 2018-01-10T15:09:45Z

src/index.js

@@ -168,6 +169,8 @@ function createConfig(options, entry, format) {
 	let cjsMain = replaceName(pkg['cjs:main'] || 'x.js', mainNoExtension);
 	let umdMain = replaceName(pkg['umd:main'] || 'x.umd.js', mainNoExtension);

+	const useBabel = !!pkg.babel || await isFile(resolve(cwd, './.babelrc')) || await isFile(resolve(cwd, './.babelrc.js'));


I'm thinking that, as long as we can get a default babel config that is as optimized as Bublé, we can just default to Babel.

Good stuff happening in terms of babel@7 in terms of outputting better tree-shakeable code & more concise/performant code, but it's still a beta. Im pretty confident in it, we have a comprehensive test suite after all, so I'm using it all over the place - aint sure though if we should promote it just yet as part of other tool (microbundle in this context) as it has potential to break some stuff. And also it might not be yet compatible with some other tooling as not every tool had an opportunity to catch up yet and provide support for it.

If we are gonna default to babel@7, Im wondering how do you plan to support babel configs? Or maybe you'd like to ignore it all along and just use internal, optimized one? Im not sure how the whole thing applies to your 0 configuration goal 😉

Personally I'd say it's better to read the real babel config, but then I'm not sure how we should "optimize" it. Mutating the input and i.e. parsing it to add loose option to plugins & presets seems a little bit magical. If one specify his/her config we should just use it as is, right?

Idea - we could possibly support babel config files without any magic, read the config files (only for validation) with some utility exposed by babel like this one and parse it (ideally we could just receive the result from babel in JSON) to warn people against using non-loose / costly stuff. WDYT?

@Andarist I spoke to Henry and I believe he mentioned they pulled the configuration parsing & lookup out of Babel into a standalone module. Maybe we can use that now?

+1 for warning, though it'd be nice to have a way to use a "stock" babel config and let microbundle tweak it into loose mode.

Andarist · 2018-01-10T16:06:08Z

Thanks for the awesome start @Andarist! I think the only things on my mind here were to make sure we were on Babel 7 so we get the updated ultra-compact loose mode and support for blacklisting regenerator (so we can still use nodent or fast-async).

Actually there is a PR for nodent support in babel - babel/babel#7076 . So maybe once it gets merged in, we could just use it as default.

corlaez · 2018-01-30T16:49:47Z

Babel has a spetial way to handle named imports that is not spec compliant, I am not sure how bublé works but I just want to be sure you have that on mind in case you plan to always switch to babel (without .babelrc present or any other indication)
Reference:

Andarist · 2018-01-30T17:15:15Z

@lrn2prgrm could you explain what do you mean by babel not being spec compliant on named imports? babel is trying to be as spec-compliant as possible by default (when i.e. buble is not trying to do that) - the only pain point is sometimes interop between esm and cjs, but that's because of how both module formats work

abusada · 2018-04-03T13:57:29Z

Hello guys, do you still plan to support babel?

Andarist · 2018-04-03T14:39:00Z

@abusada yes, I very much want this to happen, I'm just slammed with work lately

abusada · 2018-04-03T15:05:33Z

@Andarist maybe i can help, if i know what direction the maintainers would like to go in, i mean, Zero-configuration all the way or support .babelrc?

i like your idea

Idea - we could possibly support babel config files without any magic, read the config files (only for validation) with some utility exposed by babel like this one and parse it (ideally we could just receive the result from babel in JSON) to warn people against using non-loose / costly stuff. WDYT?

and i think it's the best way to move forward with supporting babel!

Andarist · 2018-04-05T15:15:23Z

In general I think this is what would be best (some of those poinst I have already stated in this thread, so might be repetitive):

support babel@7 (drop buble entirely)
provide default config if user has no .babelrc/.babelrc.js/babel.config.js - there are new APIs in babel@7 for user config inspection
even if user has custom config then we can "validate" it and suggest i.e. using loose mode, or warn about costful transforms
not yet sure what about nodent

@abusada if u want to work on it, we'd certainly appreciate the help! just let us know, we can discuss this in greater detail (if needed) on some slack (or smth else) too

developit · 2018-04-13T15:04:03Z

We'd need to run some tests to see output size of Babel vs Buble for basic stuff. For async/await there are a few decent babel plugins we could switch to.

developerdizzle · 2018-05-14T17:29:55Z

Any updates on this? I'd really like to be able to use class properties in my code.

weslleyaraujo · 2018-08-13T13:21:18Z

++ for that, missing class properties on classes too 😅

developit · 2018-08-14T02:14:28Z

This is waiting on Babel 7's official release:
https://babeljs.io/blog/2017/12/27/nearing-the-7.0-release

developerdizzle · 2018-08-14T18:10:21Z

@developit Is there any chance of having a pre-release based on 7.0.0-rc.1?

developit · 2018-08-14T19:07:52Z

Maybe!

weslleyaraujo · 2018-08-15T09:30:44Z

that would be really nice, I could test this pre-release in a internal project ☝️

developit · 2018-08-27T01:22:15Z

Update: I've run into a few bugs with Nodent. I think moving from Bublé to Babel and switching from Nodent to babel-plugin-fast-async would be a good idea.

tryzniak · 2018-08-27T13:05:42Z

Will it fix #86 ?

developit · 2018-08-27T13:49:43Z

@tryzniak yes.

developerdizzle · 2018-08-31T16:35:28Z

I'm sure you've heard, but Babel 7 is out https://babeljs.io/blog/2018/08/27/7.0.0

ezekielchentnik

needs to handle useTypescript cases as well as options.jsx for babelrc

gaui · 2018-09-09T00:47:07Z

So excited for this!

taylorjdawson · 2018-09-09T19:09:54Z

@developit How is the coming along? Really anxious to use babel with microbundle!

ForsakenHarmony · 2018-09-09T19:26:58Z

Just need a default config I'd say

paulmelnikow · 2018-12-03T20:55:09Z

Hi!

I was discussing this project at transitive-bullshit/create-react-library#104, where we're looking for an abstraction over Rollup, and wanted to check in about the status of Babel support in microbundle.

It looks like as of today:

Bublé is the transpiler
Babelrc is not respected (Doesn't seem to be paying attention to babelrc? #25)
Babel is being used in a limited way to deal with JSX (Fix jsx error #252)
There is a PR for Babel support, but it's WIP and stale ([wip] Babel support #39)

I have a couple questions:

Have the upstream blocks mentioned above been cleared at this point?
If so, would it be helpful if I revived this?

Andarist · 2018-12-03T22:29:20Z

IMHO it's time to revive this - the main blocker was preferring nodent over babel's default async functions transform. It got removed lately though in favour of babel transform so I'd say we could finally switch over to babel@7.

marvinhagemeister · 2018-12-03T23:46:39Z

+1 on reviving this PR. The code in master is already using babel@7, so it should be straightforward to build on that. It doesn't support custom babel configs yet. Note that many babel transforms generate larger output than bublé which is why the latter is used instead of babel's preset-env.

ForsakenHarmony · 2018-12-05T10:55:38Z

Seems like we have a new pr for this

[wip] Babel support

f61faca

developit self-requested a review January 10, 2018 15:06

developit reviewed Jan 10, 2018

View reviewed changes

ChristopherBiscardi mentioned this pull request Feb 26, 2018

Initialize dynamic-sampler honeycombio/dynsampler-js#1

Merged

Andarist mentioned this pull request Mar 28, 2018

Object spread seems to be failing #86

Closed

developerdizzle mentioned this pull request Apr 27, 2018

Possible bug with transforming static class properties #125

Closed

ForsakenHarmony mentioned this pull request Jul 31, 2018

Output ES modules bundles #173

Closed

ezekielchentnik reviewed Sep 7, 2018

View reviewed changes

ForsakenHarmony mentioned this pull request Nov 25, 2018

Fix jsx error #252

Merged

paulmelnikow mentioned this pull request Nov 30, 2018

Update build tools for Node 8+ mathisonian/react-editable-svg-label#5

Closed

eliihen mentioned this pull request Dec 4, 2018

Replace bublé with babel #263

Closed

ForsakenHarmony closed this Dec 5, 2018

Andarist deleted the babel-support branch December 5, 2018 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wip] Babel support #39

[wip] Babel support #39

Andarist commented Jan 9, 2018 •

edited

Loading

developit commented Jan 10, 2018

developit Jan 10, 2018

Andarist Jan 10, 2018

Andarist Jan 14, 2018

developit May 14, 2018

Andarist commented Jan 10, 2018

corlaez commented Jan 30, 2018 •

edited

Loading

Andarist commented Jan 30, 2018

abusada commented Apr 3, 2018

Andarist commented Apr 3, 2018

abusada commented Apr 3, 2018 •

edited

Loading

Andarist commented Apr 5, 2018 •

edited

Loading

developit commented Apr 13, 2018

developerdizzle commented May 14, 2018

weslleyaraujo commented Aug 13, 2018

developit commented Aug 14, 2018

developerdizzle commented Aug 14, 2018

developit commented Aug 14, 2018

weslleyaraujo commented Aug 15, 2018

developit commented Aug 27, 2018

tryzniak commented Aug 27, 2018

developit commented Aug 27, 2018

developerdizzle commented Aug 31, 2018

ezekielchentnik left a comment

gaui commented Sep 9, 2018

taylorjdawson commented Sep 9, 2018

ForsakenHarmony commented Sep 9, 2018

paulmelnikow commented Dec 3, 2018

Andarist commented Dec 3, 2018

marvinhagemeister commented Dec 3, 2018

ForsakenHarmony commented Dec 5, 2018

[wip] Babel support #39

[wip] Babel support #39

Conversation

Andarist commented Jan 9, 2018 • edited Loading

developit commented Jan 10, 2018

developit Jan 10, 2018

Choose a reason for hiding this comment

Andarist Jan 10, 2018

Choose a reason for hiding this comment

Andarist Jan 14, 2018

Choose a reason for hiding this comment

developit May 14, 2018

Choose a reason for hiding this comment

Andarist commented Jan 10, 2018

corlaez commented Jan 30, 2018 • edited Loading

Andarist commented Jan 30, 2018

abusada commented Apr 3, 2018

Andarist commented Apr 3, 2018

abusada commented Apr 3, 2018 • edited Loading

Andarist commented Apr 5, 2018 • edited Loading

developit commented Apr 13, 2018

developerdizzle commented May 14, 2018

weslleyaraujo commented Aug 13, 2018

developit commented Aug 14, 2018

developerdizzle commented Aug 14, 2018

developit commented Aug 14, 2018

weslleyaraujo commented Aug 15, 2018

developit commented Aug 27, 2018

tryzniak commented Aug 27, 2018

developit commented Aug 27, 2018

developerdizzle commented Aug 31, 2018

ezekielchentnik left a comment

Choose a reason for hiding this comment

gaui commented Sep 9, 2018

taylorjdawson commented Sep 9, 2018

ForsakenHarmony commented Sep 9, 2018

paulmelnikow commented Dec 3, 2018

Andarist commented Dec 3, 2018

marvinhagemeister commented Dec 3, 2018

ForsakenHarmony commented Dec 5, 2018

Andarist commented Jan 9, 2018 •

edited

Loading

corlaez commented Jan 30, 2018 •

edited

Loading

abusada commented Apr 3, 2018 •

edited

Loading

Andarist commented Apr 5, 2018 •

edited

Loading