allow saving files with no content or local file set yet. autosave up on file upload#27
Open
khoran wants to merge 5 commits into
Open
allow saving files with no content or local file set yet. autosave up on file upload#27khoran wants to merge 5 commits into
khoran wants to merge 5 commits into
Conversation
added 2 commits
May 30, 2024 14:05
Author
|
just fixed a typo in the first commit of this pull request that broke things. Somehow "s3" got changed to "s4". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a possible fix the issue I described here.
In the
hook_file_before_savefunction, it checks to see if a local file exists by seeing iffile_urlis set or not. If it's not set, and it's a new file, then it just does nothing. But this lets the file be saved without any content, allowing a name to be set. Then in the upload function, if the name is not set, it will call save. This no longer results in recursion as the hook will not call the upload function now.I did a bit of testing, but I imagine you have more tests you can run? I know it's kind of a central component being changed. It does allow my problem test case to work though.