Skip to content

Upgrade to become compatible with titiler.core/titiler.mosaic v0.19 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jverrydt
Copy link
Contributor

Available PR templates

@jverrydt
Copy link
Contributor Author

jverrydt commented Jul 1, 2025

@vincentsarago Tests are failing due to resampling/reproject being None. This default has been removed in the DatasetParams and it says it should take the rio-tiler's default but this does not seem to happen. Is this is a known issue or did I mis something?
https://github.com/developmentseed/titiler/blob/main/src/titiler/core/titiler/core/dependencies.py#L414-L427

@vincentsarago
Copy link
Member

@jverrydt yes, we now use .as_dict() to extract parameters from dependencies

https://github.com/developmentseed/titiler/blob/995e8330b6e695dba811c32adc5e9488b1bc2900/src/titiler/core/titiler/core/factory.py#L863-L865

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (5bd7dfd) to head (642a3af).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   81.89%   82.42%   +0.52%     
==========================================
  Files          13       13              
  Lines         856      859       +3     
  Branches      103      103              
==========================================
+ Hits          701      708       +7     
+ Misses        103      101       -2     
+ Partials       52       50       -2     
Flag Coverage Δ
unittests 82.42% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -24,8 +24,8 @@ classifiers = [
]
dependencies = [
"orjson",
"titiler.core>=0.17.0,<0.19",
"titiler.mosaic>=0.17.0,<0.19",
"titiler.core>=0.19.0,<0.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we could go up to 0.21 (there are minor changes between 0.20 et 0.21)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but now it only made it compatible to 0.19. In 0.20 there were some other breaking changes.

@@ -25,8 +25,6 @@ class STACReader(stac.STACReader):

"""

input: pystac.Item = attr.ib()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change?

I'm pretty sure we did this on purpose before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was throwing following error and it is already defined in its parent class (stac.STACReader).

ValueError: No mandatory attributes allowed after an attribute with a default value or factory. Attribute in question: Attribute(name='input', default=NOTHING, validator=None, repr=True, eq=True, eq_key=None, order=True, order_key=None, hash=None, init=True, metadata=mappingproxy({}), type=<class 'pystac.item.Item'>, converter=None, kw_only=False, inherited=False, on_setattr=None, alias=None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants