Fix for 26.40 - #101
Conversation
|
I forgot to change the config.h to soft clouds, will be changed later after I fixed the white cloud |
|
my bad there are no white clouds at night time :) I was just using the calculation where it makes the night darker as soon as it hits the expected value in my variant, making newb clouds lighter after sunset/before sunrise. |
|
Built-In Uniforms (TESTED):
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This is not precision issue with some GPUs. This is just overlapping with my rain detection logic. If you are underwater rain value becomes > 0
I'm okay with this
I'm okay with this also But I can't merge this PR. It needs some more refactoring |
- Removed unnecessary use of Day uniform
- Adjusted to properly sync it with newb's night time and so it won't show early
|
|
|
||
| /* Cloud type */ | ||
| #define NL_CLOUD_TYPE 1 // 0:vanilla, 1:soft, 2:rounded, 3:realistic | ||
| #define NL_CLOUD_TYPE 2 // 0:vanilla, 1:soft, 2:rounded, 3:realistic |
There was a problem hiding this comment.
pass env.dayFactor to function. handle masking of aurora inside it. should be like:
renderAurora(cloudPos.xyy, t, env.rainFactor, env.dayFactor)
I removed the rounded clouds terrain in this branch incase my code isn't good enough.
I'll test all override uniforms to all materials that newb shader used later.
Uniform reference, uniform marked as non-upgradable might be broken (from veka):
https://mc.163.com/dev/mcmanual/mc-dev/mcdocs/4-ShaderSDK/API%E5%8F%82%E8%80%83/4-%E5%86%85%E7%BD%AE%E5%B1%9E%E6%80%A7.html?catalog=1
resolving #99 and #100