-
Notifications
You must be signed in to change notification settings - Fork 68
Add ppc64le support for base image #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prabhuk25 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Refactor installation steps for various tools to support multiple architectures and improve error handling. Signed-off-by: Prabhu K <Prabhu.K@ib,.com>
Updated the GitHub Actions workflow to support multi-architecture builds for UBI 9 base images, including amd64, arm64, and ppc64le. Adjusted the build and publish steps accordingly. Signed-off-by: Prabhu K <Prabhu.K@ib,.com>
Refactor UBI9 build workflow for improved clarity and functionality. Signed-off-by: Prabhu K <Prabhu.K@ib,.com>
Enhanced for ppc64le arch Signed-off-by: Prabhu K <Prabhu.K@ib,.com>
Enhanced for ppc64le arch Signed-off-by: Prabhu K <Prabhu.K@ib,.com>
f9c9eea to
ad28338
Compare
dkwon17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, so far, I have a couple of comments
| amd64) GH_ARCH="linux_amd64" ;; \ | ||
| arm64) GH_ARCH="linux_arm64" ;; \ | ||
| ppc64le) GH_ARCH="linux_ppc64le" ;; \ | ||
| *) echo "Unsupported architecture: $TARGETARCH" && exit 0 ;; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we follow this case pattern for the other RUN statements (ripgrep, bat, fd, kubedock) as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per the suggestion
Co-authored-by: David Kwon <[email protected]>
Enhanced the UBI9 image for ppc64le support and modified the UBI9 build workflow to support ppc64le arch with existing runners.