[LSP-1272] feat: add workflows for deployment and environment management, update… by michael-puzon-resultscx · Pull Request #7 · devicebits/search-api-sls

michael-puzon-resultscx · 2026-02-11T08:06:12Z

Added GitHub Actions workflows for deployment and environment management. Updated serverless configuration to support new deployment processes and environment variables.

Change Log:

Added workflow files for CI/CD deployment and environment management.
Updated [serverless.yml] and [serverless.env.yml for improved deployment configuration.
Integrated environment variable handling for dev, staging, and production.

Signed-off-by: AbhishekJadhav2002 <[email protected]>

… serverless configuration

Copilot

Pull request overview

Adds GitHub Actions-based deployment workflows and updates Serverless configuration to support staged deployments (dev/staging/production) with environment-variable management.

Changes:

Introduces GitHub Actions workflows for staging/production deploys and PR-based prestage deploy/remove.
Updates serverless.yml to add provider settings (stage, VPC, deployment bucket) and custom domain configuration.
Refactors serverless.env.yml into explicit production/staging/dev blocks and adds deploy scripts to package.json.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`serverless.yml`	Adds provider defaults (stage/VPC/bucket) and custom domain configuration for deployments.
`serverless.env.yml`	Defines per-environment variables (prod/staging/dev) and defaults via YAML anchor.
`package.json`	Adds `deploy:staging` and `deploy:production` scripts for workflows.
`.gitignore`	Ignores local `mysql/` and `logs/` directories.
`.github/workflows/release-prestage.yml`	Deploys PR branches to a prestage environment.
`.github/workflows/remove-prestage.yml`	Removes PR branch deployments on PR close.
`.github/workflows/release-staging.yml`	Deploys staging on `main` pushes / manual dispatch.
`.github/workflows/release-production.yml`	Deploys production on version tag pushes.
`.github/PULL_REQUEST_TEMPLATE.md`	Adds a PR template to standardize PR context.
`.github/CODEOWNERS`	Adds code ownership configuration for review routing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/CODEOWNERS

.github/workflows/release-production.yml

.github/workflows/release-prestage.yml

.github/workflows/release-production.yml

serverless.yml

.github/workflows/release-prestage.yml

.github/workflows/remove-prestage.yml

.github/workflows/release-prestage.yml

.github/workflows/release-staging.yml

serverless.yml

.github/workflows/release-prestage.yml

.github/workflows/release-production.yml

.github/workflows/release-staging.yml

…erverless.yml framework version

Bekhzod96

Looks good !

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 13 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/release-prestage.yml

serverless.yml

.github/workflows/release-prestage.yml

.github/workflows/release-staging.yml

.github/workflows/remove-prestage.yml

.github/workflows/release-prestage.yml

.github/workflows/release-staging.yml

.github/workflows/release-prestage.yml

.github/workflows/release-production.yml

…work version in serverless configuration

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

serverless.yml:33

apiType is set to rest, but all function events are configured as httpApi (API Gateway v2 HTTP API). With serverless-domain-manager this is a mismatch and can lead to the custom domain being created/attached to the wrong API type or failing. Align these by either switching events to http (REST API) or setting apiType to the HTTP API value supported by the plugin.

    stage: ${sls:stage}
    createRoute53Record: true
    endpointType: "regional"
    apiType: "rest"
    autoDomain: true

functions:
  ingest:
    handler: src/handlers/ingestionHandler.index

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/release-prestage.yml

.github/workflows/remove-prestage.yml

.github/workflows/release-prestage.yml

.github/workflows/release-production.yml

.github/workflows/remove-prestage.yml

.github/workflows/release-prestage.yml

…tion

Copilot

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

serverless.yml:63

custom.customDomain is configured, but the serverless-domain-manager plugin has been removed from plugins, so these settings will be ignored and custom domain automation won’t run. Either re-add the plugin or remove the customDomain block to avoid a broken/unused deployment configuration.

plugins:
  - serverless-offline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

package.json

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T08:12:57Z

serverless.yml

-    prod: search.devicebits.com
+    endpointType: "regional"
+    apiType: "rest"
+    autoDomain: true


The autoDomain property is set to true, but this is not a standard serverless-domain-manager configuration option. The valid properties for serverless-domain-manager are: domainName, basePath, stage, certificateName, certificateArn, createRoute53Record, endpointType, securityPolicy, apiType, and autoDomainWaitFor. Remove this property or verify it's supported by your version of the plugin.

Suggested change

autoDomain: true

Copilot · 2026-02-27T08:12:57Z

serverless.yml

  customDomain:
-    domainName: ${self:custom.domains.${self:custom.stage}}
-    basePath: ''
-    stage: ${self:custom.stage}
+    domainName: ${env:DOMAIN_NAME, 'search-${sls:stage}.devicebits.com'}
+    basePath: ""
+    stage: ${sls:stage}
    createRoute53Record: true
-    endpointType: 'regional'
-    apiType: HTTP
-    securityPolicy: tls_1_2
-  domains:
-    dev: search-staging.devicebits.com
-    prod: search.devicebits.com
+    endpointType: "regional"
+    apiType: "rest"
+    autoDomain: true


The serverless-domain-manager plugin has been removed from the plugins section (line 62-63), but the customDomain configuration is still present. This configuration will be ignored without the plugin. Either add the serverless-domain-manager plugin back to the plugins section, or remove this customDomain configuration block.

Copilot · 2026-02-27T08:12:57Z

serverless.yml

+    securityGroupIds: ${ssm:/vpc/securityGroupIds}
+    subnetIds: ${ssm:/vpc/subnetIds}


The VPC configuration uses hardcoded SSM parameter paths (/vpc/securityGroupIds and /vpc/subnetIds) that are not environment-specific. This means all environments (dev, staging, production) will use the same VPC configuration. If you need different VPC configurations per environment, consider using environment-specific SSM paths like /${opt:stage}/vpc/securityGroupIds or document that all environments intentionally share the same VPC.

Suggested change

securityGroupIds: ${ssm:/vpc/securityGroupIds}

subnetIds: ${ssm:/vpc/subnetIds}

securityGroupIds: ${ssm:/${sls:stage}/vpc/securityGroupIds}

subnetIds: ${ssm:/${sls:stage}/vpc/subnetIds}

Copilot · 2026-02-27T08:12:58Z

serverless.yml

-    dev: search-staging.devicebits.com
-    prod: search.devicebits.com
+    endpointType: "regional"
+    apiType: "rest"


The apiType has been changed from "HTTP" to "rest" in the customDomain configuration, but all function events are using httpApi (lines 37-51 in the full file). This is a mismatch - REST APIs use http events, while HTTP APIs use httpApi events. If you're switching to REST API, update all function events from httpApi to http. If you're keeping HTTP API, change apiType back to "HTTP".

Suggested change

apiType: "rest"

apiType: "HTTP"

Copilot · 2026-02-27T08:12:58Z

package.json

  "devDependencies": {
    "serverless-domain-manager": "^8.0.0",
-    "serverless-offline": "^14.4.0"
+    "serverless-offline": "^12.0.4"


The serverless-offline version has been downgraded from ^14.4.0 to ^12.0.4. This is a major version downgrade (from v14 to v12) which could introduce compatibility issues or lose bug fixes and features from newer versions. Verify that this downgrade is intentional and necessary. If the current version of serverless (^3.30.1) requires an older version of serverless-offline, document why this downgrade was needed.

Suggested change

"serverless-offline": "^12.0.4"

"serverless-offline": "^14.4.0"

Copilot · 2026-02-27T08:12:58Z

.github/workflows/release-production.yml

+            ~/.npm
+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+
+      - name: Install dependencies


The setup-node action is configured with registry-url "https://npm.pkg.github.com" and always-auth: true, but there's no NODE_AUTH_TOKEN environment variable set for authentication. If any of your dependencies are from GitHub Packages, npm ci will fail. Add the NODE_AUTH_TOKEN environment variable to the "Install dependencies" step, e.g., env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Suggested change

- name: Install dependencies

- name: Install dependencies

env:

NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copilot · 2026-02-27T08:12:58Z

serverless.env.yml

+dev:
+  <<: *DEFAULT
+  DOMAIN_NAME: search-dev.devicebits.com
+  NODE_ENV: development
+  LOG_LEVEL: debug


The serverless.env.yml now defines three environments (production, staging, dev) but the serverless.yml defaults to 'dev' stage. However, looking at the GitHub workflows: release-staging deploys with --stage staging, and release-production deploys with --stage production. This means the default 'dev' stage might never be used in CI/CD. Consider if this is intentional or if the workflows should be updated to match the available environments.

Copilot · 2026-02-27T08:12:59Z

.github/workflows/release-production.yml

+          scope: "@devicebits"
+          always-auth: true
+
+      - name: Cache npm cache


The cache step is named "Cache npm cache" which is redundant. Consider renaming to "Cache dependencies" or "Cache npm" for consistency with the other workflows which use "Cache multiple paths".

Suggested change

- name: Cache npm cache

- name: Cache npm

Copilot · 2026-02-27T08:12:59Z

.github/workflows/release-staging.yml

+            ~/.npm
+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+
+      - name: Install dependencies


The setup-node action is configured with registry-url "https://npm.pkg.github.com" and always-auth: true, but there's no NODE_AUTH_TOKEN environment variable set for authentication. If any of your dependencies are from GitHub Packages, npm ci will fail. Add the NODE_AUTH_TOKEN environment variable to the "Install dependencies" step, e.g., env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Suggested change

- name: Install dependencies

- name: Install dependencies

env:

NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copilot · 2026-02-27T08:12:59Z

.github/workflows/remove-prestage.yml

+          key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+
+      - name: Install dependencies
+        run: npm ci


The setup-node action is configured with registry-url "https://npm.pkg.github.com" and always-auth: true, but there's no NODE_AUTH_TOKEN environment variable set for authentication. If any of your dependencies are from GitHub Packages, npm ci will fail. Add the NODE_AUTH_TOKEN environment variable to the "Install dependencies" step, e.g., env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Suggested change

run: npm ci

run: npm ci

env:

NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

…LSP-1272

dk-victory-resultscx

lgtm

AbhishekJadhav2002 and others added 2 commits February 9, 2026 17:44

chore: add deployment prod bucket configuration to serverless.yml

51f86ec

Signed-off-by: AbhishekJadhav2002 <[email protected]>

feat: add workflows for deployment and environment management, update…

e8462f8

… serverless configuration

Copilot AI review requested due to automatic review settings February 11, 2026 08:06

Copilot started reviewing on behalf of michael-puzon-resultscx February 11, 2026 08:06 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Bekhzod96 reviewed Feb 11, 2026

View reviewed changes

chore: remove Python setup and install steps from workflows, update s…

3aa2512

…erverless.yml framework version

Bekhzod96 approved these changes Feb 11, 2026

View reviewed changes

michael-puzon-resultscx requested review from a team, AbhishekJadhav2002, Bekhzod96, e-ndrus, hannahvarughese and thennil-graz February 11, 2026 13:30

feat: add npm dependency installation step to release workflows

af8fbfe

Copilot AI review requested due to automatic review settings February 11, 2026 14:56

Copilot started reviewing on behalf of michael-puzon-resultscx February 11, 2026 14:56 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

michael-puzon-resultscx added 2 commits February 11, 2026 23:01

fix: revert framework version to 3 in serverless configuration

ac05f6d

fix: remove framework version declaration from serverless configuration

45778b9

Copilot AI review requested due to automatic review settings February 11, 2026 15:06

Copilot started reviewing on behalf of michael-puzon-resultscx February 11, 2026 15:07 View session

fix: downgrade node version to 18 in workflow files and restore frame…

4734016

…work version in serverless configuration

Copilot AI reviewed Feb 11, 2026

View reviewed changes

michael-puzon-resultscx added 2 commits February 11, 2026 23:16

fix: update framework version format to "3.x" in serverless configura…

391cd46

…tion

fix: add missing comma in dependencies section of package.json

da2e578

Copilot AI review requested due to automatic review settings February 11, 2026 15:46

fix: update framework version to "3" in serverless configuration

ca39c64

Copilot started reviewing on behalf of michael-puzon-resultscx February 11, 2026 15:46 View session

fix: update package-lock.json to reflect latest dependency changes

a013b4e

[DEVOPS]: updated prestage deployment script

b10c0e6

Copilot AI review requested due to automatic review settings February 27, 2026 07:58

Copilot started reviewing on behalf of Bekhzod96 February 27, 2026 07:59 View session

devicebits deleted a comment from Copilot AI Feb 27, 2026

Copilot AI reviewed Feb 27, 2026

View reviewed changes

package.json Show resolved Hide resolved

[DEVOPS]: removing from cache node_modules

738840c

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings February 27, 2026 08:05

Copilot started reviewing on behalf of Bekhzod96 February 27, 2026 08:05 View session

devicebits deleted a comment from Copilot AI Feb 27, 2026

[DEVOPS]: removing node_moduels from cache

beb42ee

Co-authored-by: Copilot <[email protected]>

devicebits deleted a comment from Copilot AI Feb 27, 2026

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Bekhzod96 approved these changes Mar 2, 2026

View reviewed changes

Merge branch 'LSP-1272' of github.com:devicebits/search-api-sls into …

15ccf4d

…LSP-1272

Bekhzod96 approved these changes Mar 2, 2026

View reviewed changes

michael-puzon-resultscx requested a review from thennil-graz March 2, 2026 12:19

thennil-graz approved these changes Mar 2, 2026

View reviewed changes

AbhishekJadhav2002 approved these changes Mar 2, 2026

View reviewed changes

michael-puzon-resultscx requested review from dk-victory-resultscx and rcescoto March 2, 2026 12:28

rcescoto approved these changes Mar 2, 2026

View reviewed changes

Bekhzod96 merged commit 44a4811 into main Mar 2, 2026
1 check passed

dk-victory-resultscx reviewed Mar 2, 2026

View reviewed changes

		securityGroupIds: ${ssm:/vpc/securityGroupIds}
		subnetIds: ${ssm:/vpc/subnetIds}

	"serverless-offline": "^12.0.4"
	"serverless-offline": "^14.4.0"

Conversation

michael-puzon-resultscx commented Feb 11, 2026

Change Log:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bekhzod96 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!