[LSP-1319]: add wrapResponse utility and update handlers to use it and fix CORS issue#9
Merged
michael-puzon-resultscx merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared wrapResponse helper intended to standardize Lambda handler responses/errors and apply consistent CORS headers, and refactors the OpenSearch search + autosuggest handlers to use it.
Changes:
- Added
src/lib/wrap-response.jsutility to wrap handler execution and format responses. - Refactored
osSearchHandlerto delegate response formatting/CORS towrapResponse. - Refactored
osAutoSuggestHandlerto delegate response formatting/CORS towrapResponse.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/lib/wrap-response.js | New response wrapper that sets statusCode/body and adds CORS headers for success/error paths. |
| src/handlers/osSearchHandler.js | Updated to use wrapResponse and return raw results instead of a proxy response object. |
| src/handlers/osAutoSuggestHandler.js | Updated to use wrapResponse and return { suggestions, total } instead of a proxy response object. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thennil-graz
approved these changes
Mar 5, 2026
AbhishekJadhav2002
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Background:
A reusable utility was needed to standardize API responses and error handling. Additionally, there were CORS issues affecting cross-origin requests, requiring a consistent solution for all endpoints.
##Changes: