dt-bindings: chosen: Add "smbios3-entrypoint" property #177
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianicolae
force-pushed
the
chosen-smbios-binding
branch
3 times, most recently
from
d1612c9 to
0ea83a8
Compare
adrianicolae
changed the title
dtschema/schemas/chosen.yaml
Outdated
| smbios3-entrypoint: | ||
| $ref: /schemas/types.yaml#/definitions/uint64 | ||
| description: | ||
| The 64-bit physical address of the SMBIOSv3 entry point structure. |
There was a problem hiding this comment.
I am not fluent in dt-schema, so I am not sure this matters, but I'll raise it just in case: the address doesn't really need to be 64-bits. The SMBIOS3 entrypoint structure (which supersedes the SMBIOS entrypoint structure) was introduced to raise the max address of the SMBIOS table array beyond 4 GiB, but here we just need to capture the address of the entry point itself. IOW, maybe this should just be types.yaml#/definitions/address like the other fields?
There was a problem hiding this comment.
Thanks for noticing this, since it is similar to linux,initrd-start/end the address definition is better. I've updated that and also added maxItems: 1.
This property allows a bootloader to pass the physical address of the SMBIOSv3 entrypoint structure to the kernel via the /chosen node. This provides a fallback mechanism where the standard EFI configuration tables are not available but SMBIOS data is still present. Signed-off-by: adriana <[email protected]>
Adding a newline at the end of sdram-consumer.yaml because of failed check. Signed-off-by: adriana <[email protected]>
adrianicolae
force-pushed
the
chosen-smbios-binding
branch
from
34148a0 to
2b91bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bootloaders like U-boot, particularly for the ARM architecture,
provide SMBIOS/DMI tables at a specific memory address. However, these
systems often do not boot using a full UEFI environment, which means the
kernel's standard EFI DMI scanner cannot find these tables.
This property allows a bootloader to pass the physical address of the
SMBIOSv3 entrypoint structure to the kernel via the /chosen node.