Report TA003 when a strings resx name is used as a base name - #509
Merged
Conversation
kzu
enabled auto-merge (rebase)
August 27, 2026 05:46
Member
Author
🧪 Details on macOS Unix 26.5.2🧪 Details on Ubuntu 24.04.4 LTS🧪 Details on Microsoft Windows 10.0.26100from retest v1.1.0 on .NET 10.0.11 with 💜 by @devlooped |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a resource name as the underscore base of another (e.g.
SomeResourceplusSomeResource_Alt, orMSG_InstallationFailedplusMSG_InstallationFailed_Alt) used to either throw during generation or emit CS0102 on the generated class.ThisAssembly.Strings now detects that clash in both XML orders, reports TA003 with the rename-to-
_Titleworkaround, and omits the colliding base member so generation does not crash.Fixes #493