Create an exceptionhandler using generic handling with OpenAPI #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception Handling with REST always has a common problem. Somehow the exception needs to be mapped to an REST exception class. This often includes the status code of an exception, as well as further information. A naiv approach would be to add those details into the ExceptionClass, but this has two significant downsides. First of all the Rest specific information like the HTTP Status Code do not belong into the exception. They're part of the service layer. Second system specific exceptions do not contain those information. This approach here defines a generic mapper that can be controlled per exception class and that can use a behaviour per information on how to get the information. The mapper is part of the service layer and can easily be adjusted.
SchettlerKoehler
requested changes
Nov 3, 2022
.../main/java/com/baumeister/sndbx/exceptionhandling/general/exception/ValidationException.java
Outdated
Show resolved
Hide resolved
...main/java/com/baumeister/sndbx/exceptionhandling/service/exception/ProblemDetailsMapper.java
Outdated
Show resolved
Hide resolved
...main/java/com/baumeister/sndbx/exceptionhandling/service/exception/ProblemDetailsMapper.java
Outdated
Show resolved
Hide resolved
...-handling/src/main/java/com/baumeister/sndbx/exceptionhandling/domain/BookingManagement.java
Outdated
Show resolved
Hide resolved
...in/java/com/baumeister/sndbx/exceptionhandling/service/exception/CustomExceptionHandler.java
Outdated
Show resolved
Hide resolved
...exception-handling/src/main/java/com/baumeister/sndbx/exceptionhandling/DemoApplication.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/com/baumeister/sndbx/exceptionhandling/service/exception/ExceptionError.java
Outdated
Show resolved
Hide resolved
...main/java/com/baumeister/sndbx/exceptionhandling/service/exception/ProblemDetailsMapper.java
Outdated
Show resolved
Hide resolved
added 3 commits
November 4, 2022 16:16
- Rename packages - Rename classes - Remove unused classes
Added documentation of fields. Some are much easier now.
The Setters in the exceptionMappers directly put values into the ProblemDetailsTo. This can be considered a code smell, because the ProblemDetailsTo is changed hidden as a reference. Therefore, now Functions are used, that return the value that should be added to the ProblemDetailsTo. The map method created the ProblemDetailsTo and adds the values from the Functions.
SchettlerKoehler
approved these changes
Nov 17, 2022
|
Fabian Baumeister seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception Handling with REST always has a common problem. Somehow the exception needs to be mapped to an REST exception class.
This often includes the status code of an exception, as well as further information.
A naiv approach would be to add those details into the ExceptionClass, but this has two significant downsides. First of all the Rest specific information like the HTTP Status Code do not belong into the exception. They're part of the service layer.
Second system specific exceptions do not contain those information.
This approach here defines a generic mapper that can be controlled per exception class and that can use a behaviour per information on how to get the information.
The mapper is part of the service layer and can easily be adjusted.