Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the basic_bitcoin README files due to the move to testnet4 #1107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

THLO
Copy link
Contributor

@THLO THLO commented Mar 4, 2025

The Rust and Motoko basic_bitcoin examples still refer to testnet3, which is misleading since the Bitcoin testnet canister is now connected to testnet4.

This PR fixes this. Additionally, links are updated to point to the interface specification in the Bitcoin canister repository.

@THLO THLO requested a review from a team as a code owner March 4, 2025 21:44
@THLO THLO requested a review from a team as a code owner March 5, 2025 08:52
Copy link
Contributor

@berestovskyy berestovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!


This canister's `send_from_${type}` endpoint returns the ID of the transaction
it sent to the network. You can track the status of this transaction using a
[block explorer](https://en.bitcoin.it/wiki/Block_chain_browser). Once the
transaction has at least one confirmation, you should be able to see it
reflected in your current balance.

## Step 6: Retrieving block headers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is the right place but in general i think it could be helpful to explain in what situations it is helpful to have access to block headers from within a canister

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants