feat(canister_logging): add log_memory_store implementation, no-op #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymar
commented
Nov 27, 2025
maksymar
commented
Nov 27, 2025
rs/replicated_state/src/canister_state/system_state/log_memory_store/ring_buffer.rs
Outdated
Show resolved
Hide resolved
Contributor
adambratschikaye
left a comment
adambratschikaye
left a comment
There was a problem hiding this comment.
Still got a bunch more to review, just leaving some notes for now.
rs/replicated_state/src/canister_state/system_state/log_memory_store/mod.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/mod.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/mod.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/ring_buffer.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/ring_buffer.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/ring_buffer.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/index_table.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/index_table.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/mod.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/mod.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/index_table.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/mod.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/struct_io.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/struct_io.rs
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/ring_buffer.rs
Outdated
Show resolved
Hide resolved
rs/replicated_state/src/canister_state/system_state/log_memory_store/index_table.rs
Outdated
Show resolved
Hide resolved
adambratschikaye
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a no-op implementation of
log_memory_store.It serves as groundwork for a new logging system that will use
PageMapfor scalable storage.The implementation is added now so that follow-up PRs can connect it to the production code.