feat: CON-1618 IDKG hashes in blocks assembler & stripper #7849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inity/ic into eichhorl/idkg-hashes-in-blocks-sender
…rl/idkg-hashes-in-blocks-downloader
Base automatically changed from
eichhorl/idkg-hashes-in-blocks-assembler
to
master
December 2, 2025 17:40
eichhorl
added
the
CI_ALL_BAZEL_TARGETS
eichhorl
removed
the
CI_ALL_BAZEL_TARGETS
eichhorl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to conserve bandwidth, some artifacts are stripped from the block payload and replaced by hashes (IDs), before the block is transmitted. Receivers of such a block then assemble the stripped block proposal by searching for the missing artifacts in their own pools, and if they cannot be found, download them from a different peer.
Previously, only ingress messages were stripped from block proposals. With this PR, we will start to do the same for IDkg dealings. This is done by removing any IDKG dealings from the block payload, and instead only inserting their IDs into a separate payload field as part of the "stripped block proposal".
In #7794, we implemented a way to insert missing IDKG dealings that were stripped from a block into the
BlockProposalAssembler, which is the structure keeping track of all messages that are required in order to reassemble the full block proposal.This PR adds the functionality to perform the assembling of the full block proposal, given a
BlockProposalAssemblercontaining the stripped proposal, together with any missing ingress and IDKG dealing messages.Finally, we extend existing benches and unit tests for ingress messages to also cover hashes in blocks for IDKG dealings.