-
Notifications
You must be signed in to change notification settings - Fork 369
perf(ckbtc): Reduce the number of instructions to build an unsigned transaction by a factor 5x to 600x #7866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # rs/bitcoin/ckbtc/minter/canbench/results.yml # rs/bitcoin/ckbtc/minter/src/lib.rs
gregorydemay
commented
Dec 1, 2025
ninegua
reviewed
Dec 2, 2025
ninegua
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the efficiency of the ckBTC minter when handling withdrawals, where the main cost driver in terms of number of instructions is lead by finding a suitable subset of UTXOs that can be used in a Bitcoin transaction. Using the benchmarks introduced in #7782, the number of instructions required to prepare an unsigned transaction is reduced by a factor 5 to more than 600 on mainnet, depending on the withdrawal amount.
The main optimization consists of storing the UTXOs being sorted by value, instead of the canonical order defined on
ic-btc-interface::Utxoconsisting of the lexicographic order onOutPoint.