Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Show deprecation banner, remove save/store functionality #295

Merged
merged 11 commits into from
Mar 14, 2025

Conversation

fxgst
Copy link
Collaborator

@fxgst fxgst commented Mar 12, 2025

  • show deprecation banner
  • remove save/store

@fxgst fxgst force-pushed the elias/deprecation branch from 3ed8368 to 215e45d Compare March 13, 2025 22:46
@ggreif
Copy link
Contributor

ggreif commented Mar 14, 2025

I was able to deploy locally, but I see:

WARNING!
Candid interface compatibility check failed for canister 'saved'.
You are making a BREAKING change. Other canisters or frontend clients relying on your canister may stop working.

Method putProject is only in the expected type
Do you want to proceed? yes/No
yes

I guess this is intended. But please double-check.

Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Banner is well visible (ICP Ninja link works). Other stuff still works. When do you intend to deploy this to the frontend?

@fxgst
Copy link
Collaborator Author

fxgst commented Mar 14, 2025

I was able to deploy locally, but I see:

WARNING!
Candid interface compatibility check failed for canister 'saved'.
You are making a BREAKING change. Other canisters or frontend clients relying on your canister may stop working.

Method putProject is only in the expected type
Do you want to proceed? yes/No
yes

I guess this is intended. But please double-check.

Yes, this is intended. I'm removing the ability to add a stored/shared project.

@fxgst
Copy link
Collaborator Author

fxgst commented Mar 14, 2025

LGTM! Banner is well visible (ICP Ninja link works). Other stuff still works. When do you intend to deploy this to the frontend?

Great. I'd merge it now, and deploy it sometime early next week

@fxgst fxgst merged commit cfc8fbd into main Mar 14, 2025
8 checks passed
@fxgst fxgst deleted the elias/deprecation branch March 14, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants