Warm Load Improvements#1544
Open
Nick (ingalls) wants to merge 12 commits into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Codecov reporting across multiple subprojects and improves warm-load / resume behavior in the web client by reducing network-blocking paths and hardening IndexedDB/Dexie recovery on iOS WebKit.
Changes:
- Add coverage scripts (c8 / vitest v8 coverage) and upload coverage artifacts to Codecov with per-component flags.
- Refactor retention task definitions into a dedicated module and add basic task registration/enablement tests.
- Improve warm-load/resume resiliency in
api/webby adding DB reopen/retry primitives, caching TileJSON/attribution, and probing worker/main-thread DB connections on resume.
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/retention/test/tasks.test.ts | Adds unit tests validating retention task registration and enablement defaults. |
| tasks/retention/src/tasks.ts | Extracts retention task definitions and shared HTTP POST helper. |
| tasks/retention/src/index.ts | Re-exports task types/list from the new module while keeping scheduler entrypoint. |
| tasks/retention/package.json | Adds test/coverage scripts and includes tests in lint scope. |
| tasks/retention/package-lock.json | Locks new coverage-related dependencies (c8). |
| tasks/pmtiles/package.json | Adds c8-based coverage script for pmtiles task package. |
| tasks/pmtiles/package-lock.json | Locks new coverage-related dependencies (c8). |
| tasks/events/package.json | Adds c8-based coverage script for events task package. |
| tasks/events/package-lock.json | Locks new coverage-related dependencies (c8). |
| codecov.yml | Introduces flag management and broad ignore patterns for tests/dist/node_modules. |
| api/web/vite.config.ts | Enables vitest v8 coverage output (text + lcov) with include/exclude filters. |
| api/web/src/workers/atlas.ts | Uses withDbRetry for token persistence and adds a worker resume() DB probe. |
| api/web/src/workers/atlas-database.ts | Loads locally persisted features first (no network) and uses withDbRetry for DB access. |
| api/web/src/stores/map.ts | Adds foreground-resume recovery, warm-load mission rendering, overlay retry/backoff, and attribution caching. |
| api/web/src/database.ts | Adds generation-tracked reopen logic (forceReopenDatabase) and exports transient DB error detection. |
| api/web/src/components/CloudTAK/Map.vue | Suppresses transient IndexedDB errors from surfacing as user modals. |
| api/web/src/base/overlay-class.ts | Caches TileJSON in KV (without session tokens) and guards against duplicate layer adds. |
| api/web/package.json | Adds vitest --coverage script and @vitest/coverage-v8 dependency. |
| api/web/package-lock.json | Locks new vitest coverage dependencies. |
| .github/workflows/test.yml | Runs coverage in CI and uploads per-flag lcov artifacts to Codecov. |
Files not reviewed (4)
- api/web/package-lock.json: Generated file
- tasks/events/package-lock.json: Generated file
- tasks/pmtiles/package-lock.json: Generated file
- tasks/retention/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context